src/main/java/com/leets/tdd/user/service/UserService.java (1)

227-273: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Consider consolidating hasOngoingDeliveryParty/hasUnsettledDeliveryParty.

Both methods repeat the same "check creator → return true if found → skip if no joined parties → check joined ids" shape, differing only in which repository calls they delegate to. Extracting a shared helper reduces duplication as more withdrawal restrictions get added later.

♻️ Proposed refactor

+    private boolean existsAsCreatorOrParticipant(
+            List<Long> joinedPartyIds, BooleanSupplier creatorCheck, BooleanSupplier participantCheck) {
+        if (creatorCheck.getAsBoolean()) {
+            return true;
+        }
+        return !joinedPartyIds.isEmpty() && participantCheck.getAsBoolean();
+    }
+
     private boolean hasOngoingDeliveryParty(Long userId, List<Long> joinedPartyIds) {
-        if (deliveryPartyRepository.existsByCreatorIdAndStatusIn(userId, ONGOING_PARTY_STATUSES)) {
-            return true;
-        }
-        if (joinedPartyIds.isEmpty()) {
-            return false;
-        }
-        return deliveryPartyRepository.existsByIdInAndStatusIn(joinedPartyIds, ONGOING_PARTY_STATUSES);
+        return existsAsCreatorOrParticipant(joinedPartyIds,
+                () -> deliveryPartyRepository.existsByCreatorIdAndStatusIn(userId, ONGOING_PARTY_STATUSES),
+                () -> deliveryPartyRepository.existsByIdInAndStatusIn(joinedPartyIds, ONGOING_PARTY_STATUSES));
     }

     private boolean hasUnsettledDeliveryParty(Long userId, List<Long> joinedPartyIds) {
-        if (deliveryPartyRepository.existsByCreatorIdAndStatusAndSettlementStatusNotIn(
-                userId, PartyStatus.COMPLETED, SETTLEMENT_TERMINAL_STATUSES)) {
-            return true;
-        }
-        if (joinedPartyIds.isEmpty()) {
-            return false;
-        }
-        return deliveryPartyRepository.existsByIdInAndStatusAndSettlementStatusNotIn(
-                joinedPartyIds, PartyStatus.COMPLETED, SETTLEMENT_TERMINAL_STATUSES);
+        return existsAsCreatorOrParticipant(joinedPartyIds,
+                () -> deliveryPartyRepository.existsByCreatorIdAndStatusAndSettlementStatusNotIn(
+                        userId, PartyStatus.COMPLETED, SETTLEMENT_TERMINAL_STATUSES),
+                () -> deliveryPartyRepository.existsByIdInAndStatusAndSettlementStatusNotIn(
+                        joinedPartyIds, PartyStatus.COMPLETED, SETTLEMENT_TERMINAL_STATUSES));
     }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/java/com/leets/tdd/user/service/UserService.java` around lines 227 -
273, Consolidate the duplicated creator-and-participant lookup flow in
hasOngoingDeliveryParty and hasUnsettledDeliveryParty by extracting a shared
helper that accepts the relevant repository checks or predicates. Preserve the
current short-circuit behavior, including returning false when joinedPartyIds is
empty, and keep each method’s existing status and settlement criteria unchanged.